Re: pg_dump/restore --no-tableam

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Date: 2022-01-11T07:50:23Z
Lists: pgsql-hackers
On Mon, Jan 03, 2022 at 03:44:24PM -0600, Justin Pryzby wrote:
> +     <varlistentry>
> +     <varlistentry>
> +      <term><option>--no-table-am</option></term>
> +      <listitem>
> +       <para>
> +        Do not output commands to select table access methods.
> +        With this option, all objects will be created with whichever
> +        table access method is the default during restore.
> +       </para>

Hmm.  --no-table-am may not be the best choice.  Should this be called
--no-table-access-method instead?

> -	no_toast_compression => {
> -		dump_cmd => [
> -			'pg_dump', '--no-sync',
> -			"--file=$tempdir/no_toast_compression.sql",
> -			'--no-toast-compression', 'postgres',
> -		],
> -	},

Why is this command moved down?
--
Michael

Commits

  1. Fix typo in pg_dumpall.c

  2. Add support for --no-table-access-method in pg_{dump,dumpall,restore}