Re: Confused comment about drop replica identity index
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-20T11:11:04Z
Lists: pgsql-hackers
Attachments
- v2-0001-Correct-comment-and-documentation-about-REPLICA_I.patch (text/x-diff) patch v2-0001
On Mon, Dec 20, 2021 at 03:46:13AM +0000, wangw.fnst@fujitsu.com wrote: > Here is a patch to correct wrong comment about > REPLICA_IDENTITY_INDEX, And improve the pg-doc. That's mostly fine. I have made some adjustments as per the attached. + The default for non-system tables. Records the old values of the columns + of the primary key, if any. The default for non-system tables. The same sentence is repeated twice. + Records no information about the old row.(This is the default for system tables.) For consistency with the rest, this could drop the parenthesis for the second sentence. + <term><literal>USING INDEX index_name</literal></term> This should use <replaceable> as markup for index_name. Pondering more about this thread, I don't think we should change the existing behavior in the back-branches, but I don't have any arguments about doing such changes on HEAD to help the features being worked on, either. So I'd like to apply and back-patch the attached, as a first step, to fix the inconsistency. -- Michael
Commits
-
Correct comment and some documentation about REPLICA_IDENTITY_INDEX
- 9edca4cb57d2 10.20 landed
- 1a0ef5e2cc63 11.15 landed
- 861095a40987 12.10 landed
- 28e1e5c2a91c 13.6 landed
- 420f9ac1b77c 14.2 landed
- fc95d35b9429 15.0 landed
-
Add regression tests for REPLICA IDENTITY with dropped indexes
- fe7fd4e9613f 14.0 cited