Re: Assertion failure with replication origins and PREPARE TRANSACTIOn

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-14T02:14:25Z
Lists: pgsql-hackers
On Mon, Dec 13, 2021 at 07:53:43PM +0900, Michael Paquier wrote:
> Well, I don't think that it is a big deal one way or the other, as
> we'd finish with InvalidXLogRecPtr for the LSN and 0 for the timestamp
> anyway.  If both of you feel that just removing the assertion rather
> than adding an extra check is better, that's fine by me :)

Looked at that today, and done this way.  The tests have been extended
a bit more with one ROLLBACK and one ROLLBACK PREPARED, while checking
for the contents decoded.
--
Michael

Commits

  1. Remove assertion for replication origins in PREPARE TRANSACTION