Horton

Re: GUC flags

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@lists.postgresql.org, Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-12-09T08:17:54Z
Lists: pgsql-hackers 
On Wed, Dec 08, 2021 at 01:23:51PM +0100, Peter Eisentraut wrote:
> I wasn't really aware of this script either.  But I think it's a good idea
> to have it.  But only if it's run automatically as part of a test suite run.

Okay.  If we do that, I am wondering whether it would be better to
rewrite this script in perl then, so as there is no need to worry
about the compatibility of grep.  And also, it would make sense to
return a non-zero exit code if an incompatibility is found for the
automation part.
--
Michael

Commits

  1. Add TAP test to automate the equivalent of check_guc, take two

  2. Retire src/backend/utils/misc/check_guc

  3. Add TAP test to automate the equivalent of check_guc

  4. Add PostgreSQL::Test::Cluster::config_data()

  5. Introduce pg_settings_get_flags() to find flags associated to a GUC

  6. Revert changes about warnings/errors for placeholders.

  7. Improve the description of various GUCs