Horton

Re: parse_subscription_options - suggested improvements

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Smith <smithpb2250@gmail.com>
Cc: "Bossart, Nathan" <bossartn@amazon.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-08T03:51:12Z
Lists: pgsql-hackers 
On Tue, Dec 07, 2021 at 08:12:59AM +1100, Peter Smith wrote:
> On Tue, Dec 7, 2021 at 6:07 AM Bossart, Nathan <bossartn@amazon.com> wrote:
>> Attached a v14 with the initializations added back.
> 
> LGTM.

All the code paths previously covered still are, so applied this one.
Thanks!
--
Michael

Commits

  1. Improve parsing of options of CREATE/ALTER SUBSCRIPTION

  2. Refactor function parse_subscription_options.