Horton

Re: [PATCH] DROP tab completion

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Asif Rehman <asifr.rehman@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Ken Kato <katouknl@oss.nttdata.com>
Date: 2021-12-01T02:07:23Z
Lists: pgsql-hackers 
On Tue, Nov 30, 2021 at 03:17:07PM +0000, Asif Rehman wrote:
> The patch applies cleanly and the functionality seems to work well. (master e7122548a3)
> 
> The new status of this patch is: Ready for Committer

+   else if (Matches("DROP", "MATERIALIZED", "VIEW", MatchAny))
+       COMPLETE_WITH("CASCADE", "RESTRICT");
[...]
+   else if (Matches("DROP", "OWNED", "BY", MatchAny))
+       COMPLETE_WITH("CASCADE", "RESTRICT");
This stuff is gathered around line 3284 in tab-complete.c as of HEAD
at 538724f, but I think that you have done things right as there are
already sections for those commands and they have multiple keywords.
So, applied.  Thanks!
--
Michael

Commits

  1. Improve psql tab completion for various DROP commands