Re: BUG #17288: PSQL bug with COPY command (Windows)
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2021-11-28T06:40:22Z
Lists: pgsql-bugs
On Sun, Nov 28, 2021 at 01:15:36PM +0900, Michael Paquier wrote: > Using directly psql commands in the tests is not a good idea as it > makes the client-side execution more sensitive to the environment. > src/test/perl/PostgreSQL/Test/Cluster.pm does the same work, in the > wanted way, so it would be better to rely on it (see 384f1ab for one > recent issue). A test with a minimal timeout also takes time, making > for slower tests on faster machines. Or, rather than relying on a small timeout, could we just send some data to stdin and check the table's contents in return? That would make the test faster, while not penalizing the coverage. -- Michael
Commits
-
Fix compatibility thinko for fstat() on standard streams in win32stat.c
- 5550a9c38519 14.2 landed
- 58651d8dd6a5 15.0 landed
-
Fix fstat() emulation on Windows with standard streams
- d2198b4593cc 14.2 landed
- 10260c794b21 15.0 landed