Horton

Re: SSL Tests for sslinfo extension

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Andrew Dunstan <andrew@dunslane.net>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-28T04:34:45Z
Lists: pgsql-hackers 
On Sat, Nov 27, 2021 at 02:27:19PM -0500, Tom Lane wrote:
> I think testing sslinfo in src/test/ssl is fine, while putting its test
> inside contrib/ would be dangerous, because then the test would be run
> by default.  src/test/ssl is not run by default because the server it
> starts is potentially accessible by other local users, and AFAICS the
> same has to be true for an sslinfo test.

Ah, indeed, good point.  I completely forgot that we'd better control
this stuff with PG_TEST_EXTRA.
--
Michael

Commits

  1. Use test-specific temp path for keys during SSL test

  2. Add TAP tests for contrib/sslinfo

  3. Extend configure_test_server_for_ssl to add extensions