Re: docs: mention "pg_read_all_stats" in "track_activities" description
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-05-22T00:59:47Z
Lists: pgsql-hackers
On Sat, May 21, 2022 at 11:57:43AM -0700, Nathan Bossart wrote:
> Sorry, I should've noticed this yesterday. This should probably follow
> 6198420's example and say "roles with privileges of the pg_read_all_stats
> role" instead of "members of the pg_read_all_stats role."
Yes, I saw that, but that sounds pretty much the same to me, while we
mention membership of a role in other places. I don't mind tweaking
that more, FWIW, while we are on it.
> Also, I think we
> should mention that this information is visible to roles with privileges of
> the session user being reported on, too. Patch attached.
default. Note that even when enabled, this information is only
- visible to superusers, members of the
- <literal>pg_read_all_stats</literal> role and the user owning the
- session being reported on, so it should not represent a security risk.
- Only superusers and users with the appropriate <literal>SET</literal>
- privilege can change this setting.
+ visible to superusers, roles with privileges of the
+ <literal>pg_read_all_stats</literal> role, and roles with privileges of
+ the user owning the session being reported on, so it should not
+ represent a security risk. Only superusers and users with the
+ appropriate <literal>SET</literal> privilege can change this setting.
Regarding the fact that a user can see its own information, the last
part of the description would be right, still a bit confusing perhaps
when it comes to one's own information?
--
Michael
Commits
-
doc: Reword description of roles able to view track_activities's info
- 2640579bfcb6 10.22 landed
- 02ea9673382e 11.17 landed
- bc2f04e4f26e 12.12 landed
- 938548b75458 13.8 landed
- 0adff38da4bc 14.4 landed
- b3fb16e8bb3e 15.0 landed
-
doc: Mention pg_read_all_stats in description of track_activities
- fc428feafbbd 10.22 landed
- ee27871a8caa 11.17 landed
- 5f6baeea98a8 12.12 landed
- bb60f25755d4 13.8 landed
- 7f798e893678 14.4 landed
- ac1ae477f85c 15.0 landed