Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Fix description of the JIT time fields in pg_stat_statements

  1. PG15 beta1 fix pg_stat_statements view document

    Shinoda, Noriyoshi <noriyoshi.shinoda@hpe.com> — 2022-05-20T12:46:03Z

    Hi hackers,

The attached patch modifies the pg_stat_statements view documentation updated in PostgreSQL 15 Beta 1.
The data type of the following columns in the pg_stat_statements view is bigint in the current document, 
but it is actually double precision.
	jit_generation_time
	jit_inlining_time
	jit_optimization_time
	jit_emission_time

Regards,
Noriyoshi Shinoda

  2. Re: PG15 beta1 fix pg_stat_statements view document

    Nathan Bossart <nathandbossart@gmail.com> — 2022-05-20T23:04:29Z

    On Fri, May 20, 2022 at 12:46:03PM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
> The attached patch modifies the pg_stat_statements view documentation updated in PostgreSQL 15 Beta 1.
> The data type of the following columns in the pg_stat_statements view is bigint in the current document, 
> but it is actually double precision.
> 	jit_generation_time
> 	jit_inlining_time
> 	jit_optimization_time
> 	jit_emission_time

I think there is a typo in the change to the jit_optimization_time section,
but otherwise it looks good to me.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

  3. Re: PG15 beta1 fix pg_stat_statements view document

    Michael Paquier <michael@paquier.xyz> — 2022-05-21T03:32:46Z

    On Fri, May 20, 2022 at 04:04:29PM -0700, Nathan Bossart wrote:
> I think there is a typo in the change to the jit_optimization_time section,
> but otherwise it looks good to me.

Yes, as of "double precisiodouble precision".  All these four fields
are indeed doubles in the code, for what looks like a copy-pasto from
57d6aea.  Will fix.
--
Michael

  4. RE: PG15 beta1 fix pg_stat_statements view document

    Shinoda, Noriyoshi <noriyoshi.shinoda@hpe.com> — 2022-05-21T03:36:10Z

    Hi,

Thank you for your comment.
I attached the fixed patch.

-----Original Message-----
From: Michael Paquier <michael@paquier.xyz> 
Sent: Saturday, May 21, 2022 12:33 PM
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>; PostgreSQL-development <pgsql-hackers@postgresql.org>; magnus@hagander.net
Subject: Re: PG15 beta1 fix pg_stat_statements view document

On Fri, May 20, 2022 at 04:04:29PM -0700, Nathan Bossart wrote:
> I think there is a typo in the change to the jit_optimization_time 
> section, but otherwise it looks good to me.

Yes, as of "double precisiodouble precision".  All these four fields are indeed doubles in the code, for what looks like a copy-pasto from 57d6aea.  Will fix.
--
Michael

  5. Re: PG15 beta1 fix pg_stat_statements view document

    Michael Paquier <michael@paquier.xyz> — 2022-05-21T09:57:10Z

    On Sat, May 21, 2022 at 03:36:10AM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
> Thank you for your comment.
> I attached the fixed patch.

Thanks, applied.
--
Michael