Re: Possible corruption by CreateRestartPoint at promotion
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@lists.postgresql.org, masao.fujii@oss.nttdata.com
Date: 2022-05-06T23:43:27Z
Lists: pgsql-hackers
On Fri, May 06, 2022 at 08:52:45AM -0700, Nathan Bossart wrote: > I was looking at other changes in this area (e.g., 3c64dcb), and now I'm > wondering if we actually should invalidate the minRecoveryPoint when the > control file no longer indicates archive recovery. Specifically, what > happens if a base backup of a newly promoted standby is used for a > point-in-time restore? If the checkpoint location is updated and all > previous segments have been recycled/removed, it seems like the > minRecoveryPoint might point to a missing segment. A new checkpoint is enforced at the beginning of the backup which would update minRecoveryPoint and minRecoveryPointTLI, while we don't a allow a backup to finish if it began on a standby has just promoted in-between. -- Michael
Commits
-
Fix control file update done in restartpoints still running after promotion
- 60e956eb825c 10.22 landed
- 4525151d4c2f 11.17 landed
- 7e59b1219109 12.12 landed
- 2e9559b30239 13.8 landed
- 6dced63b411b 14.4 landed
- 7863ee4def65 15.0 landed