Re: pg_waldump stucks with options --follow or -f and --stats or -z
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-18T08:21:47Z
Lists: pgsql-hackers
On Thu, Nov 18, 2021 at 01:32:08PM +0530, Bharath Rupireddy wrote: > Hm. So, the pg_waldump can have handlers for SIGINT, SIGTERM, SIGQUIT > and then it should emit the computed stats in those handlers the > comobinations - "-s/-f/-z" and "-s/-e/-f/-z". I'm okay with this > behaviour. Michael Paquier had suggested the same upthread. If okay, I > will work on that patch. While on it, I am pretty sure that we should add in the stats report the start and end LSNs matching with the reports. If you use --follow and the call is interrupted, we would not really know to which part of the WAL stream a report applies to without this information, likely in the shape of an extra header. -- Michael
Commits
-
pg_waldump: Emit stats summary when interrupted by SIGINT
- f2c52eeba919 15.0 landed