Clean up build warnings of plperl with clang-12+
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-11-09T22:35:21Z
Lists: pgsql-hackers
Attachments
- plperl-clang-warnings.patch (text/x-diff) patch
Hi all, This is a follow-up of the discussion that happened here: https://www.postgresql.org/message-id/YYoJYO475dsqYhta@paquier.xyz Recently, we are getting warnings in the build of plperl when using at least clang-12 because of their new flag -Wcompound-token-split-by-macro, all the warnings coming from Perl itself. Upstream has posted a fix about that but it will take time before this propagates across the buildfarm (five~ animals are now impacted?): https://www.nntp.perl.org/group/perl.perl5.changes/2021/07/msg57758.html dangomushi is impacted by that, and I'd like to stick an -Werror in it as it is proving to be good in detecting incorrect placeholders. Tom has suggested that we could add -Wno-compound-token-split-by-macro to take care of the issue on our side, and attached is a patch to do so. Any objections? I'd like to get this back-patched. Thanks, -- Michael
Commits
-
Clean up compilation warnings coming from PL/Perl with clang-12~
- 11b05a16d462 10.20 landed
- 5e8a0dc7295f 11.15 landed
- 109279e57291 12.10 landed
- aa449e5caed8 13.6 landed
- 56eb02ce79a8 14.2 landed
- 9ff47ea414c4 15.0 landed