Re: Missing include <openssl/x509.h> in be-secure-openssl.c?
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, 近藤雄太 <kondo@sraoss.co.jp>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, buildfarm@sraoss.co.jp
Date: 2021-11-04T07:38:00Z
Lists: pgsql-hackers
On Wed, Nov 03, 2021 at 11:45:26PM -0400, Tom Lane wrote: > Yeah, I noted the comment about WIN32_LEAN_AND_MEAN in the > stackoverflow thread too ... but as you say, it seems like > that should make the problem less probable not more so. > Still, it's hard to think of any other relevant change. Yeah, I don't see how this could be linked to WIN32_LEAN_AND_MEAN. > Anyway, my thought now is (1) move the openssl includes to > after system includes in both *-secure-openssl.c files, > and (2) add comments explaining why the order is critical. > But it's late here and I'm not going to mess with it right now. > If you want to take a shot at a blind fix before hamerkop's > next run, have at it. Reading through the error logs that Thomas has posted (thanks!), I have seen error patterns like that with a dirty build repository. So it could be possible that hamerkop is reusing a directory where some code has already been compiled on. -- Michael
Commits
-
contrib/sslinfo needs a fix too to make hamerkop happy.
- 568620dfd691 15.0 landed
-
Second attempt to silence SSL compile failures on hamerkop.
- 1241fcbd7e64 15.0 landed
-
Blind attempt to silence SSL compile failures on hamerkop.
- 24f9e49e430b 15.0 landed