Re: Clean up build warnings of plperl with clang-12+

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-11T22:22:44Z
Lists: pgsql-hackers
On Thu, Nov 11, 2021 at 01:18:32PM -0500, Tom Lane wrote:
> I see you tried to do that by adding -Werror to CPPFLAGS.  That doesn't
> work because it breaks configure's tests.  (I wonder if meson is any
> smarter than autoconf about that.)  The way I do it on my own
> animals is like

Nya.  (Japanized Meh)

> if ($branch eq 'HEAD' or $branch ge 'REL9_3')
> {
>         # Add -Werror so we get errors for warning conditions.
>         # Pre-9.3 PG doesn't compile cleanly with Sierra's cc.
>         # Can't put this in CFLAGS because it breaks configure,
>         # so use COPT instead.
>         $conf{build_env}{COPT} = "-Werror";
> }
> 
> Guess I could drop the branch check now.

Thanks.  I'll switch to something like that.
--
Michael

Commits

  1. Clean up compilation warnings coming from PL/Perl with clang-12~