Horton

Re: Opclass parameters of indexes lost after REINDEX CONCURRENTLY

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-30T12:26:35Z
Lists: pgsql-hackers 
On Sat, Oct 30, 2021 at 04:11:06AM -0700, Zhihong Yu wrote:
> Should datumCopy() be used inside the loop ? I saw the following
> in get_attoptions(Oid relid, int16 attnum):

Yeah, you are right that it would be better here to use
get_attoptions() to grab a copy of each attribute's option directly
from the catalogs.  We also do that for predicates and expressions.
--
Michael

Commits

  1. Preserve opclass parameters across REINDEX CONCURRENTLY