Horton

Re: [PATCH] Prefer getenv("HOME") to find the UNIX home directory

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Anders Kaseorg <andersk@mit.edu>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-19T04:26:29Z
Lists: pgsql-hackers 
On Mon, Oct 18, 2021 at 07:23:50PM -0300, Alvaro Herrera wrote:
> I think modifying $HOME is a strange way to customize things, but given
> how widespread it is [claimed to be] today, it seems reasonable to do
> things that way.

I am not sure about this claim, but it seems to me that we could get
rid of the duplications in src/port/path.c, libpq/fe-connect.c and
psql/command.c (this one is different for WIN32 but consistency would
be a good thing) as the proposed patch outlines.  So I would suggest
to begin with that rather than changing three places to do the same
thing.
--
Michael

Commits

  1. Clean up messy API for src/port/thread.c.

  2. Prefer $HOME when looking up the current user's home directory.