Horton

Re: Fixing WAL instability in various TAP tests

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>, Andrew Dunstan <andrew@dunslane.net>, Noah Misch <noah@leadboat.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-09-29T03:15:23Z
Lists: pgsql-hackers 
On Tue, Sep 28, 2021 at 03:00:13PM -0400, Tom Lane wrote:
> Should we back-patch 0002?  I'm inclined to think so.  Should
> we then also back-patch enablement of the bloom test?  Less
> sure about that, but I'd lean to doing so.  A test that appears
> to be there but isn't actually invoked is pretty misleading.

A backpatch sounds adapted to me for both patches.  The only risk that
I could see here is somebody implementing a new test by copy-pasting
this one if we were to keep things as they are on stable branches.
--
Michael

Commits

  1. Fix instability in contrib/bloom TAP tests.

  2. Re-enable contrib/bloom's TAP tests.