Horton

Re: More business with $Test::Builder::Level in the TAP tests

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Andrew Dunstan <andrew@dunslane.net>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-08T07:51:41Z
Lists: pgsql-hackers 
On Fri, Oct 08, 2021 at 09:28:04AM +0200, Daniel Gustafsson wrote:
> LGTM.  Maybe it should be added that it *must* be called before any Test::More
> function is called, it's sort of self-explanatory but not everyone writing TAP
> tests will be deeply familiar with Perl.

I think that "must" is too strong in this context, as in some cases it
does not really make sense to increment the level, when using for
example a rather long routine that's labelled with one of the
routine arguments like for pg_rewind.  So I would stick with
"should".
--
Michael

Commits

  1. Add more $Test::Builder::Level in the TAP tests

  2. Add missing $Test::Builder::Level settings