Horton

Re: Lost logs with csvlog redirected to stderr under WIN32 service

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Chris Bandy <bandy.chris@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Andrew Dunstan <andrew@dunslane.net>
Date: 2021-10-08T02:57:27Z
Lists: pgsql-hackers 
On Thu, Oct 07, 2021 at 01:26:46PM +0900, Michael Paquier wrote:
> On Wed, Oct 06, 2021 at 09:33:24PM -0500, Chris Bandy wrote:
>>> +	/* Write to CSV log, if enabled */
>>> +	if ((Log_destination & LOG_DESTINATION_CSVLOG) != 0)
>> 
>> This was originally "if (Log_destination & LOG_DESTINATION_CSVLOG)" and
>> other conditions nearby still lack the "!= 0". Whatever the preferred
>> style, the lines touched by this patch should probably do this consistently.
> 
> Yeah.  It looks like using a boolean expression here is easier for my
> brain.

I have played with this patch more this morning, adjusted this part,
and applied it as of 8b76f89.
--
Michael

Commits

  1. Refactor fallback to stderr for csvlog to handle better WIN32 service case