Horton

Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>, "Bossart, Nathan" <bossartn@amazon.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-09-14T01:23:48Z
Lists: pgsql-hackers 
On Mon, Sep 13, 2021 at 08:51:18AM +0530, Bharath Rupireddy wrote:
> On Mon, Sep 13, 2021 at 8:07 AM Michael Paquier <michael@paquier.xyz> wrote:
>> On Sun, Sep 12, 2021 at 10:14:36PM -0300, Euler Taveira wrote:
>>> On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
>>>> nitpick: It looks like there's an extra set of parentheses around
>>>> errmsg().
>>>
>>> Indeed. Even the requirement for extra parenthesis around auxiliary function
>>> calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).

Applied.  Not using those extra parenthesis is the most common
pattern, so tweaked this way.
--
Michael

Commits

  1. Remove code duplication for permission checks with replication slots

  2. Re-implement the ereport() macro using __VA_ARGS__.