Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jacob Champion <pchampion@vmware.com>, "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "andrew@dunslane.net" <andrew@dunslane.net>
Date: 2021-08-11T00:47:38Z
Lists: pgsql-hackers
On Tue, Aug 10, 2021 at 09:36:14AM +0200, Daniel Gustafsson wrote: > I personally think the increased readability and usability from what we have > today warrants the changes. Is it the use of .SECONDARY or the change in the > global Makefile you object to (or both)? The part I am mainly objecting to is the change in Makefile.global.in, but I have to admit after thinking about it that enforcing SECONDARY may not be a good idea if other parts of the system rely on that, so encouraging the use of clean_intermediates may be dangerous (Tom's point from upthread). I have not tried so I am not sure, but perhaps we should just focus on reducing the number of openssl commands rather than making easier the integration of new files? It could be possible to close the gap with the addition of new files with some more documentation for future hackers then? -- Michael
Commits
-
Refactor the sslfiles Makefile target for ease of use
- b4c4a00eada3 15.0 landed
-
Remove unused regression test certificate server-ss
- 152c2e0ae1a8 15.0 landed