Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Jacob Champion <pchampion@vmware.com>
Cc: "daniel@yesql.se" <daniel@yesql.se>, "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "andrew@dunslane.net" <andrew@dunslane.net>
Date: 2021-08-10T07:22:55Z
Lists: pgsql-hackers
On Fri, Jul 30, 2021 at 03:11:49PM +0000, Jacob Champion wrote: > No worries, it's easy enough to unroll the expansion manually. The > annoyances without secondary expansion are the duplicated lines for > each individual CA and the need to introduce .INTERMEDIATE targets so > that cleanup works as intended. > > Attached is a v3 that does that, and introduces a fallback in case > openssl isn't on the PATH. I also missed a Makefile dependency on > cas.config the first time through, which has been fixed. The patch you > pulled out earlier is 0001 in the set. Patch 0001 is a good cleanup. Daniel, are you planning to apply that? Regarding 0002, I am not sure. Even if this reduces a lot of duplication, which is really nice, enforcing .SECONDARY to not trigger with a change impacting Makefile.global.in does not sound very appealing to me in the long-run, TBH. -- Michael
Commits
-
Refactor the sslfiles Makefile target for ease of use
- b4c4a00eada3 15.0 landed
-
Remove unused regression test certificate server-ss
- 152c2e0ae1a8 15.0 landed