Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Hans Buschmann <buschmann@nidsa.net>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2021-08-18T00:14:14Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert refactoring of hex code to src/common/
- 1900c140554e 14.0 landed
- 2576dcfb76aa 15.0 landed
Rework refactoring of hex and encoding routines
- aef8948f38d9 14.0 cited

On Tue, Aug 17, 2021 at 09:39:30AM -0400, Tom Lane wrote:
> OK, but the commit message should explain why they're getting reverted.

Sure.  aef8948 gets down because of the performance impact.  ccf4e27
was a cleanup following up aef8948, that loses its meaning.  And
c3826f8 cannot be let alone because of the reasons why aef8948 was
introduced, as it has no safety net for out-of-bound handling in the
result buffer allocated.
--
Michael