Horton

Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>, Hans Buschmann <buschmann@nidsa.net>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-08-18T00:10:16Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Revert refactoring of hex code to src/common/

  2. Rework refactoring of hex and encoding routines

On Wed, Aug 18, 2021 at 12:34:45AM +0800, Julien Rouhaud wrote:
> On Tue, Aug 17, 2021 at 11:26 PM Bruce Momjian <bruce@momjian.us> wrote:
>> Uh, I don't see those commits, e.g.:
>>
>>         $ git diff 0d70d30
>>         fatal: ambiguous argument '0d70d30': unknown revision or path not in the working tree.
>>         Use '--' to separate paths from revisions, like this:
>>         'git <command> [<revision>...] -- [<file>...]'
>>
>>         $ git diff 5c33ba5
>>         fatal: ambiguous argument '5c33ba5': unknown revision or path not in the working tree.
>>         Use '--' to separate paths from revisions, like this:
>>         'git <command> [<revision>...] -- [<file>...]'
>>
>>         $ git diff 92436a7
>>         fatal: ambiguous argument '92436a7': unknown revision or path not in the working tree.
>>         Use '--' to separate paths from revisions, like this:
>>         'git <command> [<revision>...] -- [<file>...]'
> 
> Same here.  I'm assuming that the real commits are the one mentioned
> in the patch, which are c3826f8,  aef8948 and ccf4e27.

Oops, incorrect copy-paste from my side.  Yes, the commits impacted
here are aef8948, ccf4e27 and c3826f8.  The small-ish commit message
of the patch got thet right.
--
Michael