Re: perlcritic: prohibit map and grep in void conext
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, pgsql-hackers@lists.postgresql.org
Date: 2021-07-28T04:23:12Z
Lists: pgsql-hackers
On Tue, Jul 27, 2021 at 09:09:10PM +0200, Daniel Gustafsson wrote: > On 27 Jul 2021, at 18:06, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> wrote: >> Attached is a patch that increases severity of that and the >> corresponding `grep` policy to 5 to enable it in our perlcritic policy, >> and fixes the one use that had already snuck in. > > +1, the use of foreach also improves readability a fair bit IMO. Sounds interesting to avoid. pgperlcritic does not complain here after this patch. -- Michael
Commits
-
Prohibit map and grep in void context
- bb466c6b0992 15.0 landed