Re: wrong relkind error messages

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-07-21T02:21:23Z
Lists: pgsql-hackers
On Tue, Jul 20, 2021 at 05:08:53PM +0200, Peter Eisentraut wrote:
> While reviewing the logical decoding of sequences patch, I found a few more
> places that could be updated in the new style introduced by this thread.
> See attached patch.

Those changes look fine.  I am spotting one instance in
init_sequence() that looks worth aligning with the others?

Did you consider changing RangeVarCallbackForAlterRelation() or
ExecGrant_Relation() when it came to this thread?  Just noticing that,
while going through the code.
--
Michael

Commits

  1. More improvements of error messages about mismatching relkind

  2. Improve error messages about mismatching relkind