Horton

Re: Incorrect usage of strtol, atoi for non-numeric junk inputs

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-24T10:41:12Z
Lists: pgsql-hackers 
On Thu, Jul 22, 2021 at 02:32:35PM +0900, Michael Paquier wrote:
> Okay, done those parts as per the attached.  While on it, I noticed an
> extra one for pg_dump --rows-per-insert.  I am counting 25 translated
> strings cut in total.
> 
> Any objections to this first step?

I have looked at that over the last couple of days, and applied it
after some small fixes, including an indentation.  The int64 and float
parts are extra types we could handle, but I have not looked yet at
how much benefits we'd get in those cases.
--
Michael

Commits

  1. Simplify matching pattern check in TAP tests of pg_receivewal

  2. Skip trailing whitespaces when parsing integer options

  3. Unify parsing logic for command-line integer options