Re: Why don't update minimum recovery point in xact_redo_abort

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Fujii Masao <masao.fujii@oss.nttdata.com>

Cc: 蔡梦娟(玊于) <mengjuan.cmj@alibaba-inc.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-07-27T10:51:43Z

Lists: pgsql-hackers

On Tue, Jul 27, 2021 at 05:26:05PM +0900, Fujii Masao wrote:
> ISTM that you're right. xact_redo_abort() should call XLogFlush() to
> update the minimum recovery point on truncation. This seems
> the oversight in commit 7bffc9b7bf.

Indeed.  It would be nice to see some refactoring of this code as
well?  Both share a lot of steps, so adding something to one path can
easily lead to the other path being forgotten.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Update minimum recovery point on truncation during WAL replay of abort record.
- 32d182dd0da9 9.6.23 landed
- 25fe5b2bb5fa 10.18 landed
- 02ef4d1e24b5 11.13 landed
- d7ded08e6e0e 12.8 landed
- a66b05b422d7 13.4 landed
- f2a3d7404e5d 14.0 landed
- a00c138b7852 15.0 landed
Update minimum recovery point on truncation.
- 7bffc9b7bf9e 9.3.0 cited