Re: installcheck failure in indirect_toast with default_toast_compression = lz4

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2021-06-05T01:41:31Z
Lists: pgsql-hackers
On Fri, Jun 04, 2021 at 08:28:59PM -0400, Tom Lane wrote:
> Hmm.  I'm not very clear on what that test is intending to test,
> but maybe it's dependent on pglz compression, in which case the
> right fix would be to force default_toast_compression = pglz
> for the duration of the test.

Support for external toast datums, as of 36820250, so that should be
independent on the compression method used, no?  I was just sticking
some checks based on pg_column_compression() all over the test, and
all the values are correctly getting compressed and decompressed as
far as I can see.

I got to wonder whether this is not pointing at an actual issue, and
whether it may be better to not make this test rely only on pglz, but
I have not put much thoughts into it TBH.
--
Michael

Commits

  1. Fix portability issue in test indirect_toast