Re: Move pg_attribute.attcompression to earlier in struct for reduced size?

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2021-06-04T05:24:51Z

Lists: pgsql-hackers

Attachments

vacuum-no-recompress.patch (text/x-diff) patch

On Fri, Jun 04, 2021 at 08:54:48AM +0900, Michael Paquier wrote:
> I have done no recompression here, so I was just stressing the extra
> test for the recompression.  Sorry for the confusion.

I am not sure yet which way we are going, but cleaning up this code
involves a couple of things:
- Clean up the docs.
- Update one of the tests of compression.sql, with its alternate
output.
- Clean up of reform_and_rewrite_tuple() where the rewrite is done.

So that would give the attached.
--
Michael

Commits

Remove forced toast recompression in VACUUM FULL/CLUSTER
- dbab0c07e5ba 14.0 landed
Rethink definition of pg_attribute.attcompression.
- e6241d8e030f 14.0 landed
Fix memory leak when de-toasting compressed values in VACUUM FULL/CLUSTER
- fb0f5f0172ed 14.0 landed
Re-order pg_attribute columns to eliminate some padding space.
- f5024d8d7b04 14.0 landed
Add more TAP tests for pg_dump with attribute compression
- 63db0ac3f9e6 14.0 cited