Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-02T04:29:26Z
Lists: pgsql-hackers
On Wed, Jun 02, 2021 at 01:37:51AM +0000, houzj.fnst@fujitsu.com wrote: > In the latest HEAD branch, I found some places were using > appendStringInfo/appendPQExpBuffer() when they could have been using > appendStringInfoString/ appendPQExpBufferStr() instead. I think we'd better > fix these places in case other developers will use these codes as a reference, > though, it seems will not bring noticeable performance gain. Indeed, that's the same thing as 110d817 to make all those calls cheaper. No objections from me to do those changes now rather than later on HEAD. -- Michael
Commits
-
Clean up some questionable usages of DatumGet* macros
- 8bdb36aab287 14.0 landed
-
Standardize usages of appendStringInfo and appendPQExpBuffer
- f736e188ce70 14.0 landed