Re: Move pg_attribute.attcompression to earlier in struct for reduced size?

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Andres Freund <andres@anarazel.de>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Dilip Kumar <dilipbalaut@gmail.com>, Robert Haas <robertmhaas@gmail.com>

Date: 2021-05-21T06:32:05Z

Lists: pgsql-hackers

Attachments

pg-att-align.patch (text/x-diff) patch

On Tue, May 18, 2021 at 10:24:36AM +0900, Michael Paquier wrote:
> If you switch attcompression, I'd say to go for the others while on
> it.  It would not be the first time in history there is a catalog
> version bump between betas.

This is still an open item.  FWIW, I can get behind the reordering
proposed by Tom for the consistency gained with pg_type, leading to
the attached to reduce the size of FormData_pg_attribute from 116b to
112b.
--
Michael

Commits

Remove forced toast recompression in VACUUM FULL/CLUSTER
- dbab0c07e5ba 14.0 landed
Rethink definition of pg_attribute.attcompression.
- e6241d8e030f 14.0 landed
Fix memory leak when de-toasting compressed values in VACUUM FULL/CLUSTER
- fb0f5f0172ed 14.0 landed
Re-order pg_attribute columns to eliminate some padding space.
- f5024d8d7b04 14.0 landed
Add more TAP tests for pg_dump with attribute compression
- 63db0ac3f9e6 14.0 cited