Horton

Re: Small issues with CREATE TABLE COMPRESSION

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Jacob Champion <pchampion@vmware.com>
Date: 2021-05-11T01:48:54Z
Lists: pgsql-hackers 
On Mon, May 10, 2021 at 12:17:19PM +0530, Dilip Kumar wrote:
> Even I was confused about that's the reason I used liblz4_static.lib,
> but I see you have changed to liblz4.lib to make it consistent I
> guess?

That's the name the upstream code is using, yes.

> Patch looks good to me, I can not verify though because I don't have
> such an environment.  Thanks for improving the patch.

Thanks, I got that applied to finish the work of this thread for
beta1.  At least this will give people an option to test LZ4 on
Windows.  Perhaps this will require some adjustments, but let's see if
that's necessary when that comes up.
--
Michael

Commits

  1. Add support for LZ4 build in MSVC scripts

  2. Add more TAP tests for pg_dump with attribute compression

  3. doc: Fix some gaps with the documentation related to LZ4

  4. Fix incorrect error code for CREATE/ALTER TABLE COMPRESSION

  5. Additional doc fixes for configurable TOAST compression.

  6. docs: Clarify how ALTER TABLE .. SET COMPRESSION works.