Re: Some doubious error messages and comments
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2021-05-10T06:52:15Z
Lists: pgsql-hackers
On Wed, Apr 28, 2021 at 08:11:47AM -0500, Justin Pryzby wrote:
> On Wed, Apr 28, 2021 at 05:36:33PM +0900, Kyotaro Horiguchi wrote:
>> 0001: I found some typos in a error message and a comment.
>>
>> multirangetypes.c: 1420
>> > errmsg("range_intersect_agg must be called with a multirange")));
>>
>> This "range_intersect_agg" looks like a typo of "multirange_..".
>>
>> operatorcmds.c:303
>> > * Look up a join estimator function ny name, and verify that it has the
>>
>> "ny" looks like a typo of "by".
>
> "ny name" shows up a 2nd time.
>
> I have another "comment typos" patch - maybe someone will want to push them
> together.
Thanks. Two of them were already fixed, two of them are correct but
went missing so I have applied a fix for these. The change in
multirange_intersect_agg_transfn() is incorrect as the error refers to
the SQL function range_intersect_agg().
--
Michael
Commits
-
Fix typos in operatorcmds.c
- 829daab4bbe3 14.0 landed
-
Multirange datatypes
- 6df7a9698bb0 14.0 cited
-
Add ALTER OPERATOR command, for changing selectivity estimator functions.
- 321eed5f0f75 9.6.0 cited