Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Joel Jacobson <joel@compiler.org>
Cc: pgsql-hackers@lists.postgresql.org, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2021-04-27T07:48:07Z
Lists: pgsql-hackers
Attachments
- fix_event_trigger_pg_identify_object_as_address3.patch (text/x-diff) patch
On Tue, Apr 27, 2021 at 07:16:25AM +0200, Joel Jacobson wrote: > I've added a test at the end of event_trigger.sql, > reusing the three event triggers already in existence, > just before they are dropped. Cool, thanks. I have been looking at it and I'd still like to cross-check the output data of pg_get_object_address() to see if pg_identify_object() remains consistent through it. See for example the attached that uses a trick based on LATERAL, a bit different than what's done in object_address.sql but that gives the same amount of coverage (I could also use two ROW()s and an equality, but well..). -- Michael
Commits
-
Fix pg_identify_object_as_address() with event triggers
- 6e41ff0562d3 9.6.22 landed
- 90c9bad307bf 10.17 landed
- 5b717e13c90b 11.12 landed
- 7e76cb1d82bc 12.7 landed
- f3c453787684 13.3 landed
- f7aab36d61fd 14.0 landed