Horton

Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-16T00:36:18Z
Lists: pgsql-hackers 
On Thu, Apr 15, 2021 at 07:16:05AM -0400, Andrew Dunstan wrote:
> Reviewing the history, I don't want to undo 114541d58e5.

Maybe we could remove it, but that may be better as a separate
discussion if it is proving to not improve the situation, and I don't 
really want to take any risks in destabilizing the buildfarm these
days.  

> So I'm trying your patch.

Thanks!  If you need any help, please feel free to ping me.
--
Michael

Commits

  1. Replace magic constants for seek() calls in perl scripts

  2. Allow TestLib::slurp_file to skip contents, and use as needed