Re: [PATCH] force_parallel_mode and GUC categories

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>, Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@lists.postgresql.org
Date: 2021-04-13T07:34:23Z
Lists: pgsql-hackers, pgsql-performance
On Mon, Apr 12, 2021 at 01:40:52AM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> However, I'd like to think that we can do better than what's proposed
>> in the patch.  There are a couple of things to consider here:
>> - Should the parameter be renamed to reflect that it should only be
>> used for testing purposes?
> 
> -1 to that part, because it would break a bunch of buildfarm animals'
> configurations.  I doubt that any gain in clarity would be worth it.

Okay.

>> - Should we make more general the description of the developer options
>> in the docs?
> 
> Perhaps ... what did you have in mind?

The first sentence of the page now says that:
"The following parameters are intended for work on the PostgreSQL
source code, and in some cases to assist with recovery of severely
damaged databases."

That does not stick with force_parallel_mode IMO.  Maybe:
"The following parameters are intended for development work related to
PostgreSQL.  Some of them work on the PostgreSQL source code, some of
them can be used to control the run-time behavior of the server, and
in some cases they can be used to assist with the recovery of severely
damaged databases."
--
Michael

Commits

  1. Sync guc.c and postgresql.conf.sample with the SGML docs.

  2. doc: Move force_parallel_mode to section for developer options

  3. Move log_autovacuum_min_duration into its correct sections