Re: Refactor SSL test framework to support multiple TLS libraries
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Daniel Gustafsson <daniel@yesql.se>, Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-03-30T09:53:49Z
Lists: pgsql-hackers
Attachments
- ssl-tap-refactor-simplify.patch (text/x-diff) patch
On Tue, Mar 30, 2021 at 03:50:28PM +0900, Michael Paquier wrote: > The test_*() ones are just wrappers for psql able to use a customized > connection string. It seems to me that it would make sense to move > those two into PostgresNode::psql itself and extend it to be able to > handle custom connection strings? Looking at this part, I think that this is a win in terms of future changes for SSLServer.pm as it would become a facility only in charge of managing the backend's SSL configuration. This has also the advantage to make the error handling with psql more consistent with the other tests. So, attached is a patch to do this simplification. The bulk of the changes is within the tests themselves to adapt to the merge of $common_connstr and $connstr for the new routines of PostgresNode.pm, and I have done things this way to ease the patch lookup. Thoughts? -- Michael
Commits
-
Move some client-specific routines from SSLServer to PostgresNode
- 0d1a33438d3a 14.0 landed
-
Stop requiring an explicit return from perl subroutines
- 0516f94d18c5 13.0 cited