Horton

Re: Extensions not dumped when --schema is used

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Guillaume Lelarge <guillaume@lelarge.info>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-03-30T03:02:45Z
Lists: pgsql-hackers

Attachments

On Mon, Mar 15, 2021 at 11:37:02AM +0100, Guillaume Lelarge wrote:
> Anyways. Yeah, I know we're near feature freeze. This feature would be nice
> to have, but I don't feel strongly about it. I think this feature is
> currently lacking in PostgreSQL but I don't much care if it makes it to 14
> or any future release. If you have time to work on the pg_dump test suite
> and are interested, then sure, go ahead, I'm fine with this. Otherwise I'll
> do it in a few weeks and if it means it'll land in v15, then be it. That's
> not an issue in itself.

Okay.  So I have looked at that stuff in details, and after fixing
all the issues reported upthread in the code, docs and tests I am
finishing with the attached.  The tests have been moved out of
src/bin/pg_dump/ to src/test/modules/test_pg_dump/, and include both
positive and negative tests (used the trick with plpgsql for the
latter to avoid the dump of the extension test_pg_dump or any data
related to it).
--
Michael

Commits

  1. Tweak behavior of pg_dump --extension with configuration tables

  2. Remove duplicated --no-sync switches in new tests of test_pg_dump

  3. Add support for --extension in pg_dump