Re: Log message for GSS connection is missing once connection authorization is successful.
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: vignesh C <vignesh21@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Euler Taveira <euler.taveira@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-03-20T08:37:47Z
Lists: pgsql-hackers
On Wed, Dec 02, 2020 at 02:44:31PM -0500, Stephen Frost wrote: > And committed. This has been committed as of dc11f31a, that changed the configuration of the node in the kerberos test to use logging_collector. Wouldn't it be simpler to not use the logging collector here and use a logic similar to what we do in PostgresNode::issues_sql_like() where we truncate the log file before checking for a pattern? It seems to me that this would make the tests faster, that the test would not need to wait for the logging collector and that the code could just use slurp_file($node->logfile) to get the data it wants to check for a given pattern without looking at current_logfiles. I also think that not using truncate() on the logfile generated has the disadvantage to make the code fuzzy for its verification once we introduce patterns close to each other, as there could easily be an overlap. That's one problem that SQL pattern checks had to deal with in the past. Thoughts? -- Michael
Commits
-
Simplify TAP tests of kerberos with expected log file contents
- 11e1577a576f 14.0 landed
-
Add GSS information to connection authorized log message
- dc11f31a1a89 14.0 landed