Horton

Re: Extensions not dumped when --schema is used

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Guillaume Lelarge <guillaume@lelarge.info>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Julien Rouhaud <rjuju123@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-20T23:14:45Z
Lists: pgsql-hackers 
On Sat, Feb 20, 2021 at 10:39:24PM +0100, Guillaume Lelarge wrote:
> Le sam. 20 févr. 2021 à 17:31, Tom Lane <tgl@sss.pgh.pa.us> a écrit :
>> I haven't read the patch, but the behavior I would expect is:
>>
>> 1. If --extension=pattern is given, then extensions matching the
>> pattern are included in the dump, regardless of other switches.
>> (Conversely, use of --extension doesn't affect choices about what
>> other objects are dumped.)
>>
>> 2. Without --extension, the behavior is backward compatible,
>> ie, dump extensions in an include_everything dump but not
>> otherwise.
>
> Yes, that's what it's supposed to do.

Okay, that sounds fine to me.  Thanks for confirming.
--
Michael

Commits

  1. Tweak behavior of pg_dump --extension with configuration tables

  2. Remove duplicated --no-sync switches in new tests of test_pg_dump

  3. Add support for --extension in pg_dump