Re: Add SQL function for SHA1

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Daniel Gustafsson <daniel@yesql.se>

Cc: Noah Misch <noah@leadboat.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-01-27T01:53:00Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Refactor SQL functions of SHA-2 in cryptohashfuncs.c
- f854c69a5b36 14.0 landed

Attachments

cryptohashfunc-refactor.patch (text/x-diff) patch

On Tue, Jan 26, 2021 at 10:38:43AM +0100, Daniel Gustafsson wrote:
> Agreed, and pgcrypto already allows for using sha1.
> 
> It seems like any legitimate need for sha1 could be better served by an
> extension rather than supplying it in-core.

Both of you telling the same thing is enough for me to discard this
new stuff.  I'd like to refactor the code anyway as that's a nice
cleanup, and this would have the advantage to make people look at
cryptohashfuncs.c if introducing a new type.  After sleeping about it,
I think that I would just make MD5 and SHA1 issue an elog(ERROR) if
the internal routine is taken in those cases, like in the attached.

If there are any comments or objections to the refactoring piece,
please let me know.
--
Michael