Re: More time spending with "delete pending"

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>
Date: 2021-07-06T08:33:35Z
Lists: pgsql-hackers
On Sun, Mar 14, 2021 at 06:00:00PM +0300, Alexander Lakhin wrote:
> I believe that the patch attached to [1] should fix this issue. The
> patch still applies to master and makes the demotest (attached to [2])
> pass. Also I've prepared a trivial patch that makes pgwin32_open() use
> the original stat() function (as in the proposed change for _pgstat64()).

Hmm.  Knowing that _pgfstat64() has some special handling related to
files pending for deletion, do we really need that on HEAD?

> -				struct stat st;
> +				struct microsoft_native_stat st;
>  
> -				if (stat(fileName, &st) != 0)
> +				if (microsoft_native_stat(fileName, &st) != 0)
>  				{
>  					pg_usleep(100000);
>  					loops++;

This change looks like a good idea for the WIN32 emulation of open(),
taken independently.
--
Michael

Commits

  1. Revert "Fix issues with Windows' stat() for files pending on deletion"

  2. Fix issues with Windows' stat() for files pending on deletion