Horton

Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2021-07-13T01:56:42Z
Lists: pgsql-hackers 
On Mon, Jul 12, 2021 at 07:46:32PM -0400, Tom Lane wrote:
> Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever
> as 1 or 0, but some of the entries in msvc/Solution.pm show
> such symbols as "undef" instead.  Shouldn't we fix it as
> per attached?  This is probably only cosmetic at the moment,
> but it could bite us someday if someone wrote a complex
> conditional using one of these symbols.

Hmm.  I have not tested, but agreed that this is inconsistent.  I
would tend to vote for a backpatch to keep some consistency across the
branches as changes in this area could easily lead to rather conflicts
harder to parse.
--
Michael

Commits

  1. Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix.