Horton

Re: [PATCH] Pull general SASL framework out of SCRAM

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Jacob Champion <pchampion@vmware.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-07-13T00:47:15Z
Lists: pgsql-hackers 
On Tue, Jul 13, 2021 at 12:01:46AM +0000, Jacob Champion wrote:
> Ah, right. I think the (!done && !success) case is probably indicative
> of an API smell, but that's probably something to clean up in a future
> pass.

Yeah, agreed.  I feel that it would should be cleaner to replace those
two booleans with a status enum or a bitmask.
--
Michael

Commits

  1. Install properly fe-auth-sasl.h

  2. Add more sanity checks in SASL exchanges

  3. Refactor SASL code with a generic interface for its mechanisms