Horton

Re: [PATCH] Pull general SASL framework out of SCRAM

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Mikhail Kulagin <m.kulagin@postgrespro.ru>
Cc: 'Jacob Champion' <pchampion@vmware.com>, pgsql-hackers@postgresql.org
Date: 2021-07-13T10:31:56Z
Lists: pgsql-hackers 
On Tue, Jul 13, 2021 at 12:41:27PM +0300, Mikhail Kulagin wrote:
> I got an error while building one of the extensions.
> /home/mkulagin/pg-install/postgresql-master/include/internal/libpq-int.h:44:10: fatal error: fe-auth-sasl.h: No such file or directory
>                   #include "fe-auth-sasl.h"
>                   ^~~~~~~~~~~~~~~~            

Right.  I overlooked the fact that libpq-int.h is installed.

> I think the new fe-auth-sasl.h file should be installed too.
> Correction proposal in the attached file (but I'm not sure that fix
> of Install.pm is correct). 

That looks correct to me.  I'll check that tomorrow.
--
Michael

Commits

  1. Install properly fe-auth-sasl.h

  2. Add more sanity checks in SASL exchanges

  3. Refactor SASL code with a generic interface for its mechanisms