Re: Some incorrect logs in TAP tests of pgbench

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-26T03:50:24Z
Lists: pgsql-hackers
On Fri, Jun 25, 2021 at 09:37:50AM -0400, Andrew Dunstan wrote:
> Either that or dereference them, by printing @$out and @$err instead of
> $out and $err or something similar.

Looking again, we don't really lose context if we remove that, so done
this way.

> But probably the name of the test is sufficient. (What were we thinking
> in allowing this in the first place?)

No idea.  This got introduced in v5 of what got committed as of
ed8a7c6:
https://www.postgresql.org/message-id/alpine.DEB.2.20.1705091641150.29373@lancre
--
Michael

Commits

  1. Remove some useless logs from the TAP tests of pgbench