Horton

Some incorrect logs in TAP tests of pgbench

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-25T12:33:25Z
Lists: pgsql-hackers

Attachments

Hi all,

While digging into some of the TAP tests, I have noticed that
002_pgbench_no_server.pl prints array pointers, like that:
opts=-f no-such-file, stat=1, out=ARRAY(0x1374d7990),
err=ARRAY(0x14028dc40), name=pgbench option error: no file# Running:
pgbench -f no-such-file

I am a bit dubious that this information is useful when it comes to
debugging because we have the name of the tests close by, so I would
just remove those extra logs.  If people prefer keeping this
information around, we could fix the format with something like the
attached, for example.

Thoughts?
--
Michael

Commits

  1. Remove some useless logs from the TAP tests of pgbench