Horton

Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Cc: Andrew Dunstan <andrew@dunslane.net>
Date: 2021-06-25T00:26:21Z
Lists: pgsql-hackers 
(Forgot to add Andrew in CC, now done)

On Fri, Jun 25, 2021 at 08:51:19AM +0900, Michael Paquier wrote:
> Andrew, what's the format of the per-thread logs generated on this
> host when running the commands?  I'd bet that the checks for the
> client IDs are right, but that some parts of the regex are too picky
> when it comes to this host.

I have tested that on my own Windows host using MSVC and Active Perl,
and those tests pass.  I am not sure what's happening here.  A simple
way to figure out what's going on would be to make the tests more
talkative and show up the logs that don't match.
--
Michael

Commits

  1. Cleanup some code related to pgbench log checks in TAP tests

  2. Add more debugging information with log checks in TAP tests of pgbench

  3. Fix pattern matching logic for logs in TAP tests of pgbench